Uploaded image for project: 'Magnolia Data Module (closed)'
  1. Magnolia Data Module (closed)
  2. MGNLDATA-126

SaveHandler is ignored for subtypes.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Neutral
    • None
    • 1.6.3
    • None

    Description

      Each type or subtype has its own dialog definition. If you customize the saveHandler for a type, everything is working correctly, but if you customize the saveHandler for a subtype, the definition is ignored and only the parent type saveHandler is used.
      Steps to reproduce:

      • create a new type x, with a subtype y.
      • in the dialog definition, customize the saveHandler for x with a class (Save1 extends DataSaveHandler)
      • in the dialog definition, customize the saveHandler for y with a different class (Save2 extends DataSaveHandler)
      • create a x object using the admin interface, and the called saveHandler is Save1 (which is correct)
      • create a y object under x using the admin interface, the dialog displayed is the right one for the y type, but when you save, the saveHandler called is the x one (Save1) and not the y one (Save2)

      I would expect that the saveHandler used when saving y is Save2, not Save1 of x.

      The fastest workaround (which I'm using now) is to define a single savehandler for both, and simply check the saving node type to get the right behaviour depending on the type. Not the best but at least works.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                pbaerfuss Philipp Bärfuss
                dfghi Danilo Ghirardelli
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: