Uploaded image for project: 'Magnolia Demo Projects'
  1. Magnolia Demo Projects
  2. MGNLDEMO-154

Hidden circular-dependency between travel-demo and tours module might cause trouble

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 0.11
    • 0.10
    • magnolia-travels
    • None
    • Basel 38
    • 3

    Description

      tours module is rightly depending on the travel-demo module. This enables users to install travel-demo only, without having to install the tours module. The aim is to also showcase project and module setups.

      However, page template home of travel-demo (see travel-demo/templates/pages/home.yaml) defines component availability of components that are only brought in by the tours module, such as:

      areas:
        main:
          type: list
          availableComponents:
            tourCarousel:
              id: tours:components/tourCarousel
            tourTypeTeaserRow:
              id: tours:components/tourTypeTeaserRow
            # ...
            tourList:
              id: tours:components/tourList
            # ...
      

      This results in an implicit circular dependency that needs to be resolved – even though it might not result in actual errors when adding components to that page (not yet tested).

      Possible solution

      Fix by using decoration.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                ilgun Ilgun Ilgun
                pmundt Philip Mundt
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 0.5d
                      0.5d