Uploaded image for project: 'Magnolia Diff Module'
  1. Magnolia Diff Module
  2. MGNLDIFF-100

Compare current with previous version is not aware of personalization

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Neutral
    • None
    • None
    • None

    Description

      When doing "Compare with previous version" on the travel demo home page, a broken diff is produced.

      Here are the steps to reproduce:

      1. go to Pages
      2. publish travel
      3. edit the page
      4. add a component to the main area
      5. go back to Pages
      6. click 'Compare to previous version'
      7. the diff is completely broken


      After some investigation the issue seems to be caused by the "Featured Tour Types" personalised component which is hidden by default.
      When versioning a page with such a component the versioned page is saved with the "hidden" component which is eventually displayed, whereas the current page hides it. So the diff module basically compares two different sources and correctly displays the removed images and contents for the hidden component.
      However, if one chooses the component variant "Tour type is known" and then compare the current with the previous page, the output looks correct.

      In conclusion, the diff here is a result of personalisation variants (based on a cookie in this particular case) and we need to find a way to make the action aware of all personalisation variants for the page (and the components therein) being compared in order to produce the correct diff output.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                mmichel Maxime Michel
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD