Details

    • Type: New Feature
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 1.1.3
    • Fix Version/s: 1.1.4
    • Security Level: Public
    • Labels:
      None
    • Release notes required:
      Yes

      Issue Links

        Expenses

          Activity

          Hide
          tmattsson Tobias Mattsson added a comment -

          Notes from review:

          VersionDiffHtmlServlet

          • the javadoc on the class itself refers to request parameters that are incorrect
          • the javadoc of getSourceUrl says that it will return the url with request parameters for username etc but those are added elsewhere
          • in the text of the diff view there are missing spaces, for instance: "arenot"
          • it might make sense to make the view into a ftl
          Show
          tmattsson Tobias Mattsson added a comment - Notes from review: VersionDiffHtmlServlet the javadoc on the class itself refers to request parameters that are incorrect the javadoc of getSourceUrl says that it will return the url with request parameters for username etc but those are added elsewhere in the text of the diff view there are missing spaces, for instance: "arenot" it might make sense to make the view into a ftl

            People

            • Assignee:
              had Jan Haderka
              Reporter:
              had Jan Haderka
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: