Uploaded image for project: 'Magnolia Diff Module'
  1. Magnolia Diff Module
  2. MGNLDIFF-27

Diff Module breaks install of Demo project

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Major
    • 1.x
    • 1.1.4
    • None

    Description

      I checked out 4.5.x branch (4.5.8-SNAPSHOT) and added:

          <dependency>
            <groupId>info.magnolia</groupId>
            <artifactId>magnolia-demo-project</artifactId>
            <version>2.0.9-SNAPSHOT</version>
          </dependency>
          <dependency>
            <groupId>info.magnolia</groupId>
            <artifactId>magnolia-module-inplace-templating</artifactId>;
            <version>1.3.3-SNAPSHOT</version>
          </dependency>
          <dependency>
            <groupId>info.magnolia</groupId>
            <artifactId>magnolia-module-diff</artifactId>
            <version>1.1.4-SNAPSHOT</version>
          </dependency>
      

      It fails on installing demo-project, in RepositoryBackedSecurityManager:193

      nodeID = SecuritySupport.Factory.getInstance().getGroupManager().getGroup(resourceName).getId();
      

      The group 'editors' doesnt exist. If I leave out diff it works, with diff 1.1.3 it fails too.

      The node for the editors group doesnt exist, returns null in info.magnolia.cms.security.MgnlGroupManager#getGroup line 95

          @Override
          public Group getGroup(final String name) throws AccessDeniedException {
              return MgnlContext.doInSystemContext(new SilentSessionOp<Group>(getRepositoryName()) {
      
                  @Override
                  public Group doExec(Session session) throws RepositoryException {
                      if (!session.itemExists("/" + name)){
                          return null;
                      }
                      Node groupNode = session.getNode("/" + name);
                      return newGroupInstance(groupNode);
                  }
      
                  @Override
                  public String toString() {
                      return "get group " + name;
                  }
              });
          }
      

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              tmattsson Tobias Mattsson
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD