Uploaded image for project: 'Magnolia Diff Module'
  1. Magnolia Diff Module
  2. MGNLDIFF-79

Regression: EasySslProtocolSocketFactory isn't used correctly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • 1.2.3, 1.5.4, 1.6.1
    • 1.2.1

    Description

      The implementation of MGNLDIFF-68 caused a serious regression: self-signed SSL certs are not accepted anymore.

      The bug is caused because EasySSLProtocolSocketFactory isn't used correctly anymore. The Javadoc class comment explains that one must either use relative URLs or call

      Protocol.registerProtocol("https", easyhttps);
      

      In 1.1.5 Magnolia used relative URLs. The variable in VersionDiffHtmlServlet.setHostConfiguration() is even called relUrl to make that obvious. In 1.2.1 an absolute URL is assigned to it. See VersionDiffHtmlServlet-setHostConfiguration.png

      The problem sounded somewhat familiar because I blogged about this in the past.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              pmundt Philip Mundt
              marcelstoer Marcel Stör
              Zarko Ivanoski
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD