Uploaded image for project: 'Magnolia Diff Module'
  1. Magnolia Diff Module
  2. MGNLDIFF-80

i18n aware comparison doesn't work in multisite environment

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.2.4
    • 1.2.2
    • Yes

    Description

      This feature was implemented with MGNLDIFF-70. But there is problem with multisite environment.

      DiffLink.getLocales() always return locales from default site because storageNode path start with "/activation/..." and not with actual site prefix.

      Instead getOriginalContent() should be used to aquire the proper node.

      To Reproduce:

      • In demo-features site, enable i18n
      • Add an additional locale, fr. (This is important because the problem only shows up when the locale is something that is not present in Default site definition.)
      • Edit Page /demo-features/content-templates/article, Edit the title of the "Page Header" component.
        • Make the english version 'Article EN 1', make the french version 'Article FR 1'.
      • Publish the change & Go to the Inbox and Approve the workitem.
      • Edit the page again
        • Make the english version 'Article EN 2'. make the french version 'Article FR 2'.
      • Publish the change.
      • Go to the inbox, double click on the workitem, you'll see links at the bottom to Compare for each language.
      • You'll see that English works correctly, but that French shows the English changes too!

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                pmundt Philip Mundt
                zarko.ivanoski Zarko Ivanoski
                Marcel Stör
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD