Uploaded image for project: 'Magnolia Diff Module'
  1. Magnolia Diff Module
  2. MGNLDIFF-88

IE Conditional comments breaks the diff

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.7.2
    • 1.6.2, 1.7.1
    • Chrome 42.0.2311.135
    • Yes
    • Sprint 3 (Vietnam), Sprint 4 (Basel), Basel 45
    • 2

    Description

      Having IE conditional comments before the <head> in the main template breaks the show diff functionality. This can lead to resources not loaded by being still part of the non closed comment. Find a sample script attached and resulting html attached.

      Checklists

        Acceptance criteria

        Attachments

          1. Diff-chrome.png
            Diff-chrome.png
            888 kB
          2. Diff-IE11.png
            Diff-IE11.png
            869 kB
          3. Diff-IE9.png
            Diff-IE9.png
            646 kB
          4. source-diff-mgnl.PNG
            source-diff-mgnl.PNG
            107 kB
          5. templates.templating-kit.pages.main.xml
            3 kB

          Issue Links

            Activity

              People

                mmichel Maxime Michel
                bugs Benoit Olbrechts
                Benoit Poncelet, Hugo Venancio
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - 2d
                      2d
                      Remaining:
                      Time Spent - 5h Remaining Estimate - 1d 3h
                      1d 3h
                      Logged:
                      Time Spent - 5h Remaining Estimate - 1d 3h
                      5h