Uploaded image for project: 'Solr Search Provider'
  1. Solr Search Provider
  2. MGNLEESOLR-88

Pager duplicates "currentPage" string while used with other params in link

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.0.1
    • None
    • None
    • Kromeriz 22
    • 3

    Description

      When pager is only one (or first) argument in request it works fine, when it has other arguments in front of it, it duplicates "currentPage"

      http://localhost:8080/magnoliaAuthor/member-centre/members-overview.html?queryStr=management&country=&currentPage=2&currentPage=3

      Problem starts in AbstractSearchResultModel.java when you get:

       currentPageLink = MgnlContext.getAggregationState().getOriginalURL();
      

      getOriginalURL() returns escaped string so & is returned as

      &

      there is a getOriginalBrowserURL() which returns unescaped string

      and then in SolrPager.java, in public String getPageLink(int i)
      you split parameters by :
      String[] params = query.split("&");

      which creates parameters like:

      amp;currentPage=2 and you check if string startsWith("currentPage=")

      can you please fix that?

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              ajuran AntonĂ­n Juran
              mchruscielewski Mariusz Chruscielewski
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 2d 4h 27.5m
                    2d 4h 27.5m