Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-300

Remove redundant variable "declaration"

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 1.3.1
    • None
    • None
    • None
    • DevX 17
    • 0.5

      In abstract.component.ts, we declare

      @Input() content: object;
openComment: string;
closeComment: string;
templateAnnotationSubscription: Subscription;
templateDefinitionSubscription: Subscription;

      However, we also do in sub-classes

      In editable-page.component.ts

      templateAnnotationSubscription: Subscription;
templateDefinitionSubscription: Subscription;
...
@Input() content: object;

      In editable-component.component.ts

      templateAnnotationSubscription: Subscription;
templateDefinitionSubscription: Subscription;

      These variables should be removed. They are redundant and make new devs confuse.

       

        Acceptance criteria

          1.
          		 Implement Sub-task Completed Phong Le Quoc  
          2.
          		 Review Sub-task Completed Robert Šiška  
          3.
          		 PiQA Sub-task Completed Chuong Doan Huy  
          4.
          		 QA Sub-task Completed Oanh Thai Hoang

          100%
          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 0.5h

              plequoc Phong Le Quoc
              plequoc Phong Le Quoc
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 3.5h
                    3.5h