Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-300

Remove redundant variable "declaration"

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Neutral
    • 1.3.1
    • None
    • None
    • None
    • DevX 17
    • 0.5

    Description

      In abstract.component.ts, we declare

      @Input() content: object;
      openComment: string;
      closeComment: string;
      templateAnnotationSubscription: Subscription;
      templateDefinitionSubscription: Subscription; 

      However, we also do in sub-classes

      In editable-page.component.ts

      templateAnnotationSubscription: Subscription;
      templateDefinitionSubscription: Subscription;
      ...
      @Input() content: object; 

      In editable-component.component.ts

      templateAnnotationSubscription: Subscription;
      templateDefinitionSubscription: Subscription; 
      
      

      These variables should be removed. They are redundant and make new devs confuse.

       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                plequoc Phong Le Quoc
                plequoc Phong Le Quoc
                DeveloperX
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 3.5h
                      3.5h