Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-371

Review all components' parameters to assess if it is optional or required

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.3.2
    • 1.3.1
    • None
    • None

    Description

      There's an issue reported here https://magnolia-cms.slack.com/archives/CHTPDA2NA/p1668596272059899 

      We should review all components in frontend helpers and update accordingly.


      On 1.3.1 we are seeing errors in the browser console. These should not happen.

      From Bartosz: FYI in dev mode in next js we get this:
      Warning: Failed prop type: The prop `annotation` is marked as required in `EditableComment`, but its value is `undefined`.
      From Scot:  Anybody else getting
      Warning: Failed prop type: The prop `annotation` is marked as required in `EditableComment`, but its value is `undefined`.
      Only happens outside of Magnolia, where the "templateAnnotations" is an empty object. Not a big deal, just throws ugly stack traces.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              jbenito Javier Benito
              canh.nguyen Canh Nguyen
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Work Started:

                Checklists

                  Bug DoR
                  Task DoD