Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-52

For <base href> inside magnolia the language is ignored

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • None

    Description

      when setting <base href>  inside magnolia the language is ignored.
      so e.g. my iframe is in default language then:
      iframe src is: /magnoliaAuthor/angular-minimal.html
      and base is: <base href="/magnoliaAuthor/angular-minimal"
      When I switch to german then:
      iframe src is: /magnoliaAuthor/de/angular-minimal.html
      and base is: <base href="/magnoliaAuthor/angular-minimal">  which is wrong as it should be: <base href="/magnoliaAuthor/de/angular-minimal">

      The workaround is this: https://git.magnolia-cms.com/projects/DEMOS/repos/minimal-headless-spa-demos/browse/spa/angular-minimal/src/app/app.module.ts#53
      Which imho we should make as required step and stop Magnolia adding that element.
      Why? Because when we use the languages in magnolia this base needs to be defined dynamically, not on a build level, as we do not want to have separate build for separate languages...

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              bstaryga Bartosz Staryga
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Task DoD