Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-526

eslint config of angular-editor is wrong

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.4
    • None
    • None
    • None

    Description

      When running npm run lint, there is an error for angular-editor. Should be changed to 

      "project": [
        "./projects/angular-editor/tsconfig.lib.json",
        "./projects/angular-editor/tsconfig.spec.json"
      ], 

      in packages/angular-editor/projects/angular-editor/.eslint.json. However, IntelliJ will show an error (IntelliJ is wrong) when open .ts files in angular-editor. We should find a way that is accepted by Lerna and IntelliJ also. If satisfy both takes time, we could go with Lerna only.

      Note:

      1. The code generated by Angular does not contain "project" attributes in .eslint.json files of angular editors. In addition, tried to remove the attributes and there are no errors, however, we should find out if it is suitable for our project or not.

      2. In IntelliJ, we can config eslint working directory point to ./packages/angular-editor to eliminate the error, however, we have some projects so it could be have many values. Reference: https://youtrack.jetbrains.com/issue/WEB-47135/Allow-to-configure-working-directory-for-ESLint-process

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              plequoc Phong Le Quoc
              plequoc Phong Le Quoc
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Work Started:

                Checklists

                  Bug DoR
                  Task DoD

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 7.75h
                    7.75h