Details
-
Story
-
Resolution: Fixed
-
Neutral
-
None
-
None
-
None
-
-
Empty show more show less
-
DevX 42, DevX 43, DevX 44
-
5
-
Yes
Description
EditableComment (interactivity component)
- Convert all class components to function components: https://nextjs.org/docs/messages/class-component-in-server-component
- Replace componentDidMount, componentDidUpdate, and componentWillUnmount with effect hook https://legacy.reactjs.org/docs/hooks-overview.html
- alwaysRender props should pass from parent component. Detect alwaysRender via #magnoliaContext.isMagnolia from EditorContextHelper
- Add 'use client' in top of file ( react will ignore it by default so maybe no harm at all)
Ref code in proposal PR: https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/220/diff#samples/next-js-13-with-react-editor-new/packages/react-wrap-client-component-typescript/src/WrapperEditableComment.tsx
Checklists
Acceptance criteria
Attachments
Issue Links
- is causing
-
MGNLFE-617 Variants menu and green bar position are wrong
-
- Closed
-
- is depended upon by
-
MGNLFE-565 Refactor EditableArea
-
- Closed
-
-
MGNLFE-566 Refactor EditablePage
-
- Closed
-
-
MGNLFE-567 Refactor EditableComponent
-
- Closed
-
There are no Sub-Tasks for this issue.