Details
-
Improvement
-
Resolution: Done
-
Neutral
-
None
-
None
-
None
-
-
Empty show more show less
-
Yes
-
DevX 50
-
1
-
Yes
Description
Update the current dynamic component creation code to be compatible with Angular 14+.
Context:
In the current implementation we face these challenges:
1. Deprecated factory: We are using the deprecated `ComponentFactoryResolver`.
2. Property vs Input:
Currently, all properties of a Magnolia node are set directly as properties on the corresponding Angular component.
This bypasses the distinction between properties and inputs in Angular, resulting in an inability to use inputs as they were intended. This has implications on component lifecycle and binding capabilities.
Current workaround forces us to interface with Angular’s internal API, as we can’t determine if a property of a magnolia node is supposed to be handled as an input or a property.
Proposed solution:
PR #226
1. Replace the deprecated factory
2. Distinguish Properties vs Inputs:
Before assigning properties from Magnolia nodes, verify if they should be set as inputs on the Angular component. This will enable the proper use of lifecycle hooks, directives, and other features that rely on inputs.
Checklists
Attachments
Issue Links
- is depended upon by
-
MGNLFE-682 Release angular-editor 1.5 to npm based on Angular 1.5
-
- Closed
-
- relates to
-
MGNLFE-708 SPA: Update minimal-headless-spa-demos to angular-editor v1.5
-
- Closed
-
- to be documented by
-
MGNLFE-701 DOC: Update dynamic component creation for Angular 14+ compatibility
-
- Closed
-
- mentioned in
-
Page Loading...
1.
|
Implementation |
|
Completed | Robert Šiška |
2.
|
Review |
|
Completed | Rishab Dhar |
3.
|
PiQA |
|
Closed | Unassigned |
4.
|
QA |
|
Completed | Canh Nguyen |