Uploaded image for project: 'Magnolia Form Module'
  1. Magnolia Form Module
  2. MGNLFORM-234

ValidateExpression should not extend NoHTMLValidator, as it prohibits valid password characters

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 2.2.8
    • 2.2.5
    • validation
    • Yes

    Description

      The regexp based validator:
      info.magnolia.module.form.validators.ValidateExpression
      extends the class:
      info.magnolia.module.form.validators.NoHTMLValidator

      Using the NoHTMLValidator as a base class for all other fields makes sense, as it prohibits html characters in form fields. But the NoHTMLValidator prohibits characters which are perfectly fine as password characters.

      So the ValidateExpression should directly extends the base class Validator, and if by default it still should constrain by the html characters, it should directly be added to the used expression itself. So its obvious and easy changeable.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              fgrilli Federico Grilli
              cringele Christian Ringele
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD