Uploaded image for project: 'Google Sitemap (closed)'
  1. Google Sitemap (closed)
  2. MGNLGS-128

Export action extends export from admincentral for no reason

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 2.4.1
    • None
    • None
    • Kromeriz 74
    • 3

    Description

      Action + extends

      /subApps/browser/actions/export extends /modules/ui-admincentral/apps/configuration/subApps/browser/actions/export. However, as the screenshots show, we should not do this if, out of three properties, we override one and don't need another (e.g. command) (additionally info.magnolia.module.googlesitemap.app.actions.ExportSiteMapToXMLActionDefinition doesn't extend info.magnolia.ui.api.action.CommandActionDefinition, the source of the actual problem).

      app: siteMaps
      from jcr
      at /modules/google-sitemap/apps/siteMaps
      Source data processing problem: Property [command] not found in class [info.magnolia.module.googlesitemap.app.actions.ExportSiteMapToXMLActionDefinition], property is not assigned: /subApps/browser/actions/export
      

      See: /modules/google-sitemap/apps/siteMaps/subApps/browser/actions/export@extends

      Action – unknown property

      app: siteMaps
      from jcr
      at /modules/google-sitemap/apps/siteMaps
      Source data processing problem: Property [nodeType] not found in class [info.magnolia.ui.framework.action.OpenEditDialogActionDefinition], property is not assigned: /subApps/browser/actions/editSiteMap
      

      See: /modules/google-sitemap/apps/siteMaps/subApps/browser/actions/editSiteMap@nodeType

      Dialog field – unknown property + node name

      Also these old properties can go:

      dialog: google-sitemap:components/content/siteComponentTab
      from jcr
      at /modules/google-sitemap/dialogs/components/content/siteComponentTab
      Source data processing problem: Property [chooseOnClick] not found in class [info.magnolia.ui.form.field.definition.MultiValueFieldDefinition], property is not assigned: /form/tabs/tabSites/fields/mgnl:googleSiteMapPages
      

      Apart from removing the stray property chooseOnClick we should also rename node to mgnl-googleSiteMapPages (notice the dash vs. colon) and add property name=mgnl:googleSiteMapPages.

      See: /modules/google-sitemap/dialogs/components/content/siteComponentTab/form/tabs/tabSites/fields/mgnl:googleSiteMapPages

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              rsiska Robert Šiška
              mmichel Maxime Michel
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: