Uploaded image for project: 'Multiple Pages Apps '
  1. Multiple Pages Apps
  2. MGNLMULTPA-55

Provide generic keys for dialogs

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 1.0.0
    • None
    • None
    • DevX 52
    • 2

    Description

      There are some dialog labels that say "Pages", but none should by default. 

      Consider the case that develoer creaates another app called "banners", then it is confusing if when they click the "Add Item" action - they get a dialog that saays "Add Page".

      Known cases:

      Browser view: Add item

      Browser view: Rename Item

      Technical notes

      I think these keys come from here: 

      https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-pages-app/src/main/resources/pages-app/i18n/pages-app-browser_en.properties

      However - solving this seems a little tricky - because the key is identified by the name of the module "pages-app". So how can we have a label that says "Add page" when used in the pages app - but "Add item" when used in a custom pages app? 

      I don't think its possible to set a key based on which App is currently live.

      I think a solution could be to create NEW dialogs "createItem" and renameItem" in the multiple-paages-apps-editor module  and have the custom pages app point to those dialogs in its "action" definitions.

       

      It might be easy to create these dialogs using definition inheritance:

      https://docs.magnolia-cms.com/product-docs/6.2/Developing/Reusing-configuration/YAML-inherit-and-include.html#_yaml_inherit

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              chuong.doan Chuong Doan Huy
              czimmermann Christopher Zimmermann
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Work Started:

                Checklists

                  Task DoR

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 1d 5h
                    1d 5h