Details
-
Improvement
-
Resolution: Won't Do
-
Major
-
None
-
4.0
-
None
-
-
Empty show more show less
Description
There are few things that are necessary to keep the code maintainable:
- at various places exceptions are used to transfer the result of methods (e.g. JcrPackagedNode.checkForChange()
- the properties are duplicated in the packaged nodes (all properties are available in the exported xml as well as in the <NodeDataList> subelements. This is unnecessary and blows up the size and memory footprint of the packager.
- the packaged nodes are processed in-memory most of the time which blows when package contains big media files.
- jar files are opened and parsed at various places and processed multiple times in consequent operations which makes whole processing slower (e.g. the change list is generated once when the dialog is open and second time when user hits the "install package" button from the very same dialog.
- usage of Vector all around the place should be unnecessary.
- module would benefit moving to Java 5 baseline and from introducing generics.
Checklists
Acceptance criteria