Uploaded image for project: 'Magnolia Personalization'
  1. Magnolia Personalization
  2. MGNLPN-331

VariantManager#VARIANT_NODE_PATH_PATTERN matches incorrecly for non variant in a variant

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3.1, 1.4
    • Component/s: Component p13n
    • Labels:
      None
    • Sprint:
      Kromeriz 68
    • Story Points:
      3
    • Magnolia Release:
      5.4.10, 5.5

      Description

      ?variant-([0-9]+) matches incorrectly nodes in a variant. As this is not an issue for a page variant (since we don't support subpages), it's a problem for component personalization:
      /page/area/component/variants/variant-0/componentInVariant
      namely in:
      info.magnolia.personalization.decoration.PersonalizationNodeWrapper#PersonalizationNodeWrapper:

      ....
      } else if (VARIANT_NODE_PATH_PATTERN.matcher(wrapped.getPath()).find()) { //should match rather node name instead of path or just the end of the path
                //HERE     
      } else if
      ...
      

        Attachments

          Activity

            People

            • Assignee:
              jsimak Jaroslav Simak
              Reporter:
              rkovarik Roman Kovařík
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: