-
Bug
-
Resolution: Fixed
-
Major
-
None
-
None
-
-
Empty show more show less
-
Saigon 158
-
5
Acceptance criteria:
- Move the view out of the dialog and back into a normal app (Plain, regular app with a tabsheet layout. Could be based on the old UI framework.)
- Don't attempt full screen like in M5 yet. We do that in a follow up.
- Don't attempt action bar restyling. We do that in a follow up as well.
Background
—currently accidentally ended up displayed in a dialog
https://slack-files.com/T4J2HS2LU-FDWTKE8E6-9be3065ab5
Mikaël Geljić [15:45]
@Ilgun re: p13n preview app, my guess is that this used to call the deprecated overlay API directly—now the new Shell wraps any "unknown view" into a dialog. When you close the dialog, it doesn't close the background app that was started. There was also a special hook for closing the app in the old impl iirc. We should probably adjust this app for M6 (with new major of p13n), and make it a real app instead of an overlay?Aleksandr Pchelintcev [15:46]
for that we’d need to expand the API for opening the apps beyond the tabsheet limitsMikaël Geljić [15:47]
would it be that bad if it were a regular subapp?Aleksandr Pchelintcev [15:48]
dunno, I think the whole purpose of the app initially was to provide the real experience without mgnlMikaël Geljić [15:48]
at least in a first step; with a custom AppView impl you don't necessarily need the tabsheet btw, but I'm not sure whether the app/instance controllers are fully lenient thereAleksandr Pchelintcev [15:48]
they should be actually - worth checking out
re: closing the app now - I think it should be still doable iirc it was based on the app lifecycle events
- is depended upon by
-
MGNLPN-433 Resurface field type: custom field types in personalization
- Closed