Uploaded image for project: 'Magnolia Personalization'
  1. Magnolia Personalization
  2. MGNLPN-464

Some @Data annotated classes do not include fields from superclass in equals / hashCode

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 2.0
    • None
    • None
    • None
    • UI Framework & 6.2 Ramp up 15
    • 1

      Lombok's @Data annotation does not include fields from the super class in the generated equals and hashCode methods. This can lead to subtle bugs when instances of such classes are used as keys in a map. We should use the @EqualsAndHashCode(callSuper = true) annotation where necessary to explicitly include fields of super classes. Potential candidates are:

      • info.magnolia.personalization.ui.TraitVoterItemProvider.Definition

       

        Acceptance criteria

              mduerig Michael Duerig
              mduerig Michael Duerig
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD