Uploaded image for project: 'Magnolia Personalization'
  1. Magnolia Personalization
  2. MGNLPN-89

Move preview parameter interfaces to integration module so they can be used in the trait registry

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: Integration, Preview App
    • Labels:
      None

      Description

      These classes should be moved:

      • info.magnolia.personalization.preview.parameter.PreviewParameterDefinition
      • info.magnolia.personalization.preview.parameter.PreviewParameterConverter

      The info.magnolia.personalization.preview.filter.PreviewFilter currently uses preview parameters defined in info.magnolia.personalization.PreviewAppModule but should rather use the one that will be defined in each info.magnolia.personalization.registry.TraitDefinition (where the name of the trait will also be used as previewParameterName (prefixed accordingly)). This mean injecting the info.magnolia.personalization.registry.TraitDefinitionRegistry.

      Other tasks:

      • TraitClass is defined still in both TraitDefinition and PreviewParameterDefinition. We need to get rid one of them.
      • The same applies for name property.
      • Duplicated code in PreviewParameterConverterServiceImpl vs PreviewFilter.
      • TraitDefinition should probably have enabled property.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rkovarik Roman Kovařík
              Reporter:
              pmundt Philip Mundt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response: