-
Task
-
Resolution: Fixed
-
Neutral
-
None
-
None
-
-
Empty show more show less
-
Empty show more show less
These classes should be moved:
- info.magnolia.personalization.preview.parameter.PreviewParameterDefinition
- info.magnolia.personalization.preview.parameter.PreviewParameterConverter
The info.magnolia.personalization.preview.filter.PreviewFilter currently uses preview parameters defined in info.magnolia.personalization.PreviewAppModule but should rather use the one that will be defined in each info.magnolia.personalization.registry.TraitDefinition (where the name of the trait will also be used as previewParameterName (prefixed accordingly)). This mean injecting the info.magnolia.personalization.registry.TraitDefinitionRegistry.
Other tasks:
- TraitClass is defined still in both TraitDefinition and PreviewParameterDefinition. We need to get rid one of them.
- The same applies for name property.
- Duplicated code in PreviewParameterConverterServiceImpl vs PreviewFilter.
- TraitDefinition should probably have enabled property.
Acceptance criteria
- mentioned in
-
Wiki Page Loading...