Uploaded image for project: 'Magnolia Resources Module'
  1. Magnolia Resources Module
  2. MGNLRES-262

Don't depend upon CSS classes as literals in ResourcesColumnFormatterTest

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4.5
    • Component/s: None
    • Labels:
    • Sprint:
      Saigon 35
    • Story Points:
      5
    • Magnolia Release:
      5.4.6

      Description

      • In workbench we updated activation states using new icons. Please update ResourcesStatusColumnFormatterTest to use the new activation state icons. If we don't do it and merge MGNLUI-3596 to UI, the build would fail.
      • We created the CSS constants in StatusColumnFormatter that you can reuse.
        public static final String ACTIVATION_STATUS_MODIFIED_STYLE = "activation-status icon-status-orange color-yellow";
        public static final String ACTIVATION_STATUS_ACTIVATED_STYLE = "activation-status icon-status-green color-green";
        public static final String ACTIVATION_STATUS_NOT_ACTIVATED_STYLE = "activation-status icon-status-red color-red";
        

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              oanh.thai Oanh Thai Hoang
              Reporter:
              hieu.nguyen Hieu Nguyen Duc
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 3d
                  3d
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 5h Time Not Required
                  5h