Details
-
Improvement
-
Resolution: Duplicate
-
Neutral
-
None
-
3.0.4
-
None
Description
Tab characters are disallowed in YAML files for formatting. However when hotfixing a resource the system does not block users from adding them. This can lead to a corrupted system in some cases.
Reproduce
- Hotfix the file /admincentral/config.yaml with the following YAML
findBar: suggestionCountPerSupplier: 3 defaultCountPerSupplier: 10 suppliers: - name: pages - name: assets - name: faq - name: contact-channels-app - name: search-widgets-app appLauncherLayout: defaultGroup: edit hiddenApps: notifications: notifications # contacts-v8 groups: - name: edit - Try and search with the FindBar --> 0 results

- Try and open app by directly manipulating the url. Appending /.magnolia/admincentral#app:resources (or any other app) does nothing

Actual
The system is broke and app are unreachable.
Expected
The user should have been warned about the tab characters upon save and blocked from saving a corrupted configuration.
Workaround
Remove all hotfixes
- Shut down.
- Delete the resources workspace.
- Delete the 4 tables for resources (if applicable).
- Start back up.
Notes
We should apply the same type of validation we do for Groovy code. For example I am unable to save a Groovy class which is not well formed or broken in some way.
Checklists
Acceptance criteria
Attachments
Issue Links
- is superseded by
-
MGNLRES-372 Validate hotfixes upon save
-
- Closed
-