Details
-
Improvement
-
Resolution: Fixed
-
Neutral
-
None
-
None
-
None
-
-
Empty show more show less
-
Yes
-
Yes
-
Declarative REST 4
-
8
Description
Rationale
We've got some issues with modifying requests that are already declared in the configuration. Modifications to original rest calls lead into undesired behavior. Moreover, with introduction of info.magnolia.rest.client.call.AbstractRestCall and it's subclasses back then, i've added unnecessary abstraction layer above JAX-RS abstraction, that makes working with rest client very cumbersome.
Proposal
Declare rest calls using definitions, make them utilize JAX-RS API directly, removing implementations of info.magnolia.rest.client.call.AbstractRestCall. Make JAX-RS API available through the info.magnolia.rest.client.RestClient, the info.magnolia.rest.client.RestClient could be a mere provider of configured rest calls with almost no logic inside.
Things to consider
As aichimescu pointed out in the discussion, we should make sure, that it is not possible to deduct passwords for 3rd party APIs rest client is connecting to.
Checklists
Attachments
Issue Links
- is depended upon by
-
MGNLRESTCL-42 Easy REST calls from templates
-
- Closed
-
- supersedes
-
MGNLRESTCL-49 Conceptualize versatile definitions
-
- Closed
-