Uploaded image for project: 'Magnolia Site Module'
  1. Magnolia Site Module
  2. MGNLSITE-100

Missing Imaging configuration can lead to exceptions

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Neutral
    • None
    • 1.3.1
    • None

    Description

      When using a theme if you have a missing imaging configuration this can lead to exceptions in apps and other places that can be hard to diagnose. By simply adding the imaging node without any sub-configuration the problems can be overcome. It seems logical that ConfiguredTheme class should simply initialize its imaging member by default to avoid such issues.

      Recreate the issue by installing a vanilla magnolia without the demo. Inside the Resource Files app perform the following steps:

      • Add a themes registry to the mtk module
      • Add a mtk.yaml theme but leave the file blank
      • Create/Override a dialog to link to the dam:
            image:
              label: Select image
              $type: linkField
              chooser:
                workbenchChooser:
                  appName: dam-chooser
        

      In the Site app, configure the fallback site definition to use the mtk theme.

      From the Pages app try to link to an image in the dam. This creates a stack overflow in the log similar to the one attached image-error.txt.

      The dam chooser is configured to create a variation of the image with the name 240. This ends up being passed to the render() method of ImagingBasedAssetRenderer. This calls:

      imagingSupport.createLink(jcrDataProperty, renditionName);
      

      Here is the beginning of a bunch or recursive calls that leads to the stack overflow.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                rgange Richard Gange
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 5h
                      5h