Uploaded image for project: 'Magnolia Site Module'
  1. Magnolia Site Module
  2. MGNLSITE-60

Themes added by using the old mechanism (backwards-compatible) are not decorateable

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.1
    • None
    • None
    • None

    Description

      When themes are placed in config:/modules/site/config/themes/<theme-name> they are not decorateable.

      This is due to backwards-compatible code setting the raw-view of the theme to an empty String when it's added to the registry.

      When adding the theme to config:/modules/<my-module>/themes/<theme-name> everything works according to plan.

      When added by using the new mechanism however, themes will not show up in the themes app (see MGNLSITE-56 – which will most likely be rendered as won't fixed once definitions app is there).

      Implemented solution

      Instead of creating the theme with en empty raw view, we now determine the raw view from the theme node itself – enabling decoration of that theme.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                apchelintcev Aleksandr Pchelintcev
                pmundt Philip Mundt
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD