-
Improvement
-
Resolution: Won't Do
-
Neutral
-
None
-
2.0.6
-
None
-
-
Empty show more show less
When extending an STK template, one has to extend info.magnolia.module.templatingkit.templates.pages.STKPage if they want to add custom areas or configuration. That's fair.
But if the custom template also needs a model, it seems unnecessary that they also have to extend info.magnolia.module.templatingkit.templates.pages.STKPageModel - because i.e htmlHeader.ftl uses pageModel.logoImageLink and pageModel.site.
It seems to be cluttering a class that should really be about "business logic" with layout logic. Some of these methods would probably be better off in stkfn... but some cases are debatable. Just leaving this here as food for thought. (Also because there is a lot of duplication or close-but-not-quite-the-same similarity between STKPageModel and functions of stkfn.