Uploaded image for project: 'Magnolia Standard Templating Kit (closed)'
  1. Magnolia Standard Templating Kit (closed)
  2. MGNLSTK-1087

ImagingSupport.resolveVariationName() should work like a proper css selector mechanism

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Neutral
    • 2.0.x
    • 2.0.6
    • None

    Description

      CssSelectorBuilder builds a nice and long selector from the known css classes and ids in the definitions. Then ImagingSupport.resolveVariationName() simply maps the variations rule to this selector and returns the first variation which matches.

      This system does not correspond to how css selectors work (and therefore to what the users are used to). The resolving mechanism should not select the first but the best matching variation (IDs over classes, more matches over less).

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              will Will Scheidegger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1d
                  1d
                  Remaining:
                  Remaining Estimate - 1d
                  1d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified