Uploaded image for project: 'Magnolia Standard Templating Kit (closed)'
  1. Magnolia Standard Templating Kit (closed)
  2. MGNLSTK-721

DialogDAM: Should be extendable for usage within data module - getDamSupport() should be protected

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Minor
    • 1.4.x
    • 1.3.5, 1.4
    • controls
    • None
    • Yes

    Description

      For usage of the DAM Dialog/Control within the data module, the class DialogDAM.java should be expendable.
      When using within the data module, the detection of a DAMSupport configuration out of a site definition can't work.
      There for the method getDamSupport() should be protected, for providing a DAMSupport configuration from other places.
      Second the access to the non existing DAMSupprt will result in a null violation within the constructor.
      I have added comments to the code how I think it should be solved (always returning the default site definition at least).

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                cringele Christian Ringele
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: