Uploaded image for project: 'Magnolia Standard Templating Kit'
  1. Magnolia Standard Templating Kit
  2. MGNLSTK-721

DialogDAM: Should be extendable for usage within data module - getDamSupport() should be protected

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Do
    • Affects Version/s: 1.3.5, 1.4
    • Fix Version/s: 1.4.x
    • Component/s: controls
    • Labels:
      None
    • Patch included:
      Yes

      Description

      For usage of the DAM Dialog/Control within the data module, the class DialogDAM.java should be expendable.
      When using within the data module, the detection of a DAMSupport configuration out of a site definition can't work.
      There for the method getDamSupport() should be protected, for providing a DAMSupport configuration from other places.
      Second the access to the non existing DAMSupprt will result in a null violation within the constructor.
      I have added comments to the code how I think it should be solved (always returning the default site definition at least).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              cringele Christian Ringele
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response: