Uploaded image for project: 'Magnolia Standard Templating Kit (closed)'
  1. Magnolia Standard Templating Kit (closed)
  2. MGNLSTK-721

DialogDAM: Should be extendable for usage within data module - getDamSupport() should be protected

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • 1.4.x
    • 1.3.5, 1.4
    • controls
    • None
    • Yes

      For usage of the DAM Dialog/Control within the data module, the class DialogDAM.java should be expendable.
      When using within the data module, the detection of a DAMSupport configuration out of a site definition can't work.
      There for the method getDamSupport() should be protected, for providing a DAMSupport configuration from other places.
      Second the access to the non existing DAMSupprt will result in a null violation within the constructor.
      I have added comments to the code how I think it should be solved (always returning the default site definition at least).

        Acceptance criteria

          1. magnolia-module-standard-templating-kit.patch
            2 kB

              Unassigned Unassigned
              cringele Christian Ringele
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: