-
Improvement
-
Resolution: Fixed
-
Neutral
-
1.4.1
-
None
-
-
Empty show more show less
The current STK pom files declare a dependency to the forum module, which afaik is not used nor needed. (It would be needed for commenting, which is only added with the ETK)
Consequences:
- forum module is added to the stk-bundle (unneeded?)
- modules depending on stk transitively depend on the forum, thus requiring several tedious exclusions.
For the record, here's the output of mvn dependency:analyze, which shows more missing and superfluous dependencies (with a pinch of salt, as the dependency to the taglib is needed, for instance - it's used in the template, but not in code, which is why mvn dependency:analyze considers it unneeded)
[INFO] [dependency:analyze {execution: default-cli}] [WARNING] Used undeclared dependencies found: [WARNING] commons-lang:commons-lang:jar:2.4:provided [WARNING] javax.jcr:jcr:jar:1.0:provided [WARNING] org.slf4j:slf4j-api:jar:1.5.11:provided [WARNING] commons-collections:commons-collections:jar:3.2.1:provided [WARNING] rome:rome:jar:1.0:compile [WARNING] log4j:log4j:jar:1.2.16:provided [WARNING] info.magnolia:magnolia-gui:jar:4.4.1:provided [WARNING] javax.servlet:servlet-api:jar:2.4:provided [WARNING] commons-beanutils:commons-beanutils:jar:1.7.0:provided [WARNING] info.magnolia:magnolia-module-exchange-simple:jar:4.4.1:provided [WARNING] Unused declared dependencies found: [WARNING] info.magnolia:magnolia-module-forum:jar:1.2.1:compile [WARNING] org.easymock:easymockclassextension:jar:2.4:test [WARNING] com.mockrunner:mockrunner:jar:0.3.1:test [WARNING] info.magnolia:magnolia-module-fckeditor:jar:4.4.1:provided [WARNING] info.magnolia:magnolia-taglib-utility:jar:4.4.1:provided [WARNING] info.magnolia:magnolia-module-form:jar:1.2:compile [WARNING] info.magnolia:magnolia-taglib-cms:jar:4.4.1:provided [WARNING] cglib:cglib-full:jar:2.0.2:compile [WARNING] javax.servlet:jsp-api:jar:2.0:provided [WARNING] info.magnolia:magnolia-module-scheduler:jar:1.4:compile
Additionally, we also see side effects, for instance in user role bootstrap files:
$ grep -ri forum . ./src/main/resources/mgnl-bootstrap/standard-templating-kit/userroles.contact-base.xml: <sv:node sv:name="acl_forum">
Acceptance criteria
- is causing
-
MGNLETK-47 add an explicit dependency to the forum module
- Closed