Details
-
Improvement
-
Resolution: Done
-
Neutral
-
None
-
None
-
-
Empty show more show less
-
Yes
-
Yes
-
Maintenance 11, Maintenance 12, Maintenance 13
-
8
Description
See the review items on the original ticket:
https://jira.magnolia-cms.com/browse/MGNLSYNC-40?focusedCommentId=208822&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-208822
Successfully merged basic functionality and released a 1.9-beta1; Here are additional review items for 2nd-stage review:
- REST API review - not a problem to change provided we produce a change log / release notes
- Rename 'repository' params back to 'workspace'
- Date resolution for the endpoint (help define expected ISO date string format?)
- Unbox booleans where applicable
VH for module config and command bootstraps?non-applicable for new module- Move manager to synchronization-core
- Builder for SynchronizationRequest + pass as param to #synchronize(SyncRequest), #canSynchronize...
- Remove XML output from endpoint (non-goal)
- Consider ITs for endpoint?
- Test method signatures: throw general Exception & no test prefix (BDD-style naming)
- Failing existing synchronization command tests – failing on JDK12, passing on JDK8
- Validate module config vs. manager, drop module lifecycle?
- Reconsider deduplicating `SynchronizationCommand` (preferably evolving or partially deprecating the old one)
- Global policy? //remove setter on manager, move the configuration under module config
Checklists
Acceptance criteria
Attachments
Issue Links
- caused by
-
MGNLSYNC-40 Add support for invoking synchronization asynchronously
-
- Closed
-
- relates to
-
MGNLSYNC-42 Synchronization manager does not complete normally
-
- Closed
-
- to be documented by
-
MGNLSYNC-49 DOC: Synchronization module changes for 1.9
-
- Closed
-