Details
-
Bug
-
Resolution: Fixed
-
Neutral
-
None
-
1.1.0
Description
We did raised test-fwk to 1.1.0 on both dx-core and ce.
While it works fine on ce, dx-core constantly failed. For an example of a failed build on jenkins see https://jenkins.magnolia-cms.com/job/platform/job/dx-core/job/master/296/.
It also fails on local envs. Stacktrace from local failure: https://gist.github.com/Watcher24/0a851157d06e36a9c72eaa1e45d47028
Seems to be a docker issue.
java.lang.NoClassDefFoundError: Could not initialize class info.magnolia.test.setup.DockerHelper
I reverted the 2 latest commits, now dx-core INT tests run again ... at least they have no docker issues. (Some tests arbitrary fail now and then ... but for other reason.)
Here’s probably a hint why it fails: https://github.com/testcontainers/testcontainers-java/issues/2860
slack discussion of the issue: https://magnolia-cms.slack.com/archives/CG69M3JGG/p1617080918009700
Identified problem and proposed solution(s) (by Sasha)
Problem:
testcontainers dependency is old! (we now use the 1.15.1 vs 1.8.3 there).
This comes from ce/magnolia-integration-tests/magnolia-integration-tests-framework/pom.xml
lines 169ff
Possible solutions:
- let the test-fw to bring it in transitively (not great)
- bump the version explicitly
- synch the dependency version over boms
For the time being, we bump the version in magnolia-integration-tests-framework/pom.xml.
Checklists
Attachments
Issue Links
- relates to
-
MGNLTEST-151 raise org.testcontainers:testcontainers to 1.15.1; remove SeleniumNodeVncSidekickContainer
-
- Closed
-
- mentioned in
-
Page Loading...