Uploaded image for project: 'Magnolia Test Framework'
  1. Magnolia Test Framework
  2. MGNLTEST-173

Fix timing issues on Form P.O.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None

    Description

      Context

      Issues appear e.g. on

      1. #setTextField -> leads to validation error (see Detail example of a failure below)
      2. #save ->  leads to an issue - if the form has not yet disappeared as expected. 

       


      Detail example of a failure

      I  (Maxime) was testing upgrading Docker when I ran into this failing test. It looks like the test algorithm is not accounting for all the internal dialog mechanics. When slowed down, what happens is the following:

      1. dialog opens
      2. field is cleared
      3. 'Save changes' button is clicked
      4. validation error happens
      5. new name is typed into the field (too late)

      Which obviously leads to a failed test.

       


      Acceptance criteria

      • Usage of form field setter methods work reliable.
      • Have test methods on FormTest with repetitions (via JUnit).
      • If possible - use VaadinWebDriverWrapper to ensure async communication with the server is finished.

      Developper notes

      A 1st PR was using Selenium to check whether "things are done"

      • whether a field has the expected value after setting it.
      • whether the form disappeared
        But that seems too explicit. Instead  we should rather check whether async communication to server is done.

       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                mmichel Maxime Michel
                Foundation
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Work Started:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 2d 1.5h
                      2d 1.5h