Uploaded image for project: 'Magnolia Test Framework'
  1. Magnolia Test Framework
  2. MGNLTEST-186

Remove copy-pasted code from testcontainers

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 1.2.4
    • None
    • None
    • Global Maintenance 1, Global Maintenance 2
    • 5

    Description

      The TF has a ton of legacy code to deal with VNC recordings, i.e. SeleniumNodeVncSidekickContainer is mostly a copy-paste of a testcontainers class. This is a problem to maintain the project, for instance upgrade testcontainers to 1.5.3 which provides OOTB options to record to MP4.

      Rishab says he has an effort to address this that he would only need to wrap up. The solution is to extract the spinning up of containers from jvm to a separate docker container spun up from docker-compose.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                rdhar Rishab Dhar
                mmichel Maxime Michel
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 1.5h
                      1.5h