Details
-
Improvement
-
Resolution: Outdated
-
Neutral
-
None
-
2.0-cloud
Description
MGNLTEST-163 has been merged to the cloud-feature branch for some time; few weeks back, I had proceeded with further review, for what I deem necessary to address to merge it back to the main branch as 2.0:
- We don't have good conventions yet for naming MP Config keys, but would suggest magnolia.test as prefix
- DirectInstances terminology sounds legacy or too technical to be used for defaults, pbly sth like DefaultInstances?
- Backwards compatibility: we accept that @Fixture, @Cleanup annotations' instances parameter type is moving from enum to plain Strings. We also wanted to deprecate the constants or enum members prefixed with 'DIRECT_' anyway, so tests will need an update, worth doing it in one go.
- Can @WithName smallrye annotations be replaced with MP config annotations?
- InstancesManager may be an injectable component w/ MP config mappings, so we resolve config only upon init; might also expose the instance stream or collection to facilitate functional operations.
Checklists
Acceptance criteria
Attachments
Issue Links
- supersedes
-
MGNLTEST-163 Make configurable list of test instances
-
- Closed
-
- mentioned in
-
Page Loading...