Details
-
Improvement
-
Resolution: Duplicate
-
Neutral
-
None
-
None
-
None
Description
Consider removing some VaadinWebElementWrapper#vaadinIsDone calls - or refine
We wrap some of our WebElements in Page Objects with the VaadinWebElementWrapper and then have calls #vaadinIsDone.
The idea is to let wait selenium until am async Vaadin call is done.
For an example see info.magnolia.test.selenium.pageobjects.Badge#open
The problem is - that we sometimes run into situations where "vaadin maybe is never done" - at least we run into timeouts.
(See error-log cioy/paste on gist )
The above described issue - "vaadin maybe is never done" - seems to be the underlying issue of MGNLTEST-198.
It also seems to be the reason when
expect.tasksBadge().open();
fails that often e.g. in PublicationWorkflowFunctionalTests (see MGNLEE-687).
My impression is that we use #vaadinIsDone too often.
We may want to consider removing some of the #vaadinIsDone calls - or we should rewrite it / refine it. At some point we should stop the checks and just try to proceed (returning true in #vaadinIsDone)
Or maybe can refine it.