Uploaded image for project: 'Magnolia Test Framework'
  1. Magnolia Test Framework
  2. MGNLTEST-364

Improve/fix Selenium#newRemoteWebDriver to harmonize with SaasWebdriver for random selenium-ports

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Done
    • Neutral
    • 1.4.1
    • None
    • None

    Description

      In Selenium#newRemoteWebDriver, we assign the URL for the remoteWebdriver, before instantiating the WebDriver (which then gets wrapped with VaadinWebDriverWrapper).

      In SaasWebdriverConfiguration, we set (again!) remoteWebdriverUrl - for Selenide.
      This all works totally fine, if the port is constant, and so far "we" always have used constant port 4444 (for ce, dx-core, magnolia-cloud/e2e, saas-TF ...)
      but on subscription-service-ui/e2e we must use random port, random-number created on Jenkins. If randomPort !=4444, we have a missmatch, which I guess is the reason for the exception

      org.openqa.selenium.SessionNotCreatedException: Could not start a new session. Possible causes are invalid address of the remote server or browser start-up failure.

      I know that the driverSetup looks complicated, IS complicated.
      But it makes sense, to let us use some config, browsers settings, etc. pp, for core-TF, core-tests, saas-TF, saas-tests, etc. pp

      How it can be fixed hopefully:

      In Selenium#newRemoteWebDriver, before assembling seleniumServerUrl:
      Check whether we have systemProperty for "remote.driver.url.
      If yes: Use it
      Else: Assemble it as it was before

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              cmeier Christoph Meier
              cmeier Christoph Meier
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Work Started:

                Checklists

                  Task DoD

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 2.5h
                    2.5h