Uploaded image for project: 'Magnolia Test Framework'
  1. Magnolia Test Framework
  2. MGNLTEST-75

Some integration test setting names aren't clear enough and/or don't reflect the actual state things

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Neutral
    • 1.0.1
    • None
    • None

    Description

      • private/public ports can now be configured as a single host port: since we're moving to the Docker-compose based setup, we can alway communicate with the instance over the same port.
      • references to container, like e.g. directContainerRootURL are confusing: introduced before we introduced Docker there, 'container' implied the servlet container.
      • clarify the host name strategy as much as possible:
        • we have a "REST client case", i.e. when an external http client outside of Docker needs to access the running instance. We simply name such host name as hostName since it is the one visible to the whole world. By default such host name is localhost.
        • we also have the "selenium worker case" - typically from within Docker container running the workers. In this case localhost wouldn't obviously work, and we access magnolia instances via special Docker container-to-host IP/Hostname (172.17.0.1/host.docker.internal for macs).
      • Instance#getDomain -> Instance#getContextRoot: domain is a bit misleading here. The #getContextPath can be renamed also to hopefully clearer {{getWebappPath.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              apchelintcev Aleksandr Pchelintcev
              apchelintcev Aleksandr Pchelintcev
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD