Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-195

implement JcrPropertyAdapter updating logic

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.0
    • None
    • None
    • None

    Description

      JcrPropertyAdapter was never used prior to inplace editing, so as in MGNLUI-164 for reading vaadin Properties out of a JcrPropertyAdapter, we need to be able to update the JcrPropertyAdapter back with edited values from these vaadin Properties.

      First difference to NodeAdapters is that they listen to valueChanges from the DefaultProperties they generate. PropertyAdapters should do as well.

      Then the JcrItem within a PropertyAdapter is currently the parent Node, which is wrong. It means we cannot get the JCR Property from the repository after init, using the getJcrItem() method from the AbstractJcrAdapter interface.

      One thing to note is that some refactoring may be necessary to mutualize more code between NodeAdapters and PropertyAdapters and review the levels of abstraction, which are not clear right now. But this is out of scope for the present task.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD