Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-1991

Cleanup Actionbar dependencies and apply proper MVP pattern

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.3
    • Component/s: actionbar
    • Labels:

      Description

      The Actionbar widget currently implements the View interface (ui-api) instead of having the ActionbarPresenter produce a ViewImpl that uses the Widget internally. There are also further issues that do not fall inline with the MVP pattern.

      • The widget should be ui-api agnostic.
      • The ActionbarPresenter should inject the ActionbarView
        • remove direct instantiations of the ActionbarPresenter along the way
      • The ActionbarFactory (produces a widget based on config) should be inlined inside the ActionbarPresenter.
      • The ActionbarPresenter.Listener interface shouldn't be used to get action label and icon, instead the map of ActionDefinitions should be passed into the presenter upon startup.

        Checklists

        Acceptance criteria

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                mgeljic Mikaël Geljić
                Reporter:
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Checklists

                    Task DoR