Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2195

i18n - Forms and dialogs are not properly decorated

    XMLWordPrintable

Details

    • Bug
    • Resolution: Obsolete
    • Critical
    • None
    • 5.1
    • None
    • None

    Description

      Fixes for MGNLUI-2135 are unsatisfactory.

      One of the reasons is that some presenters pass an already-decorated definition to info.magnolia.ui.dialog.BaseDialogPresenter#start, and some don't. After an initial analysis with [@pbaerfuss], we thought we'd move that responsibility to the caller. After further investigation:

      • There are "too many" places where this should occur, and that would somewhat hide/obscure the calls to I18nizer.
      • DialogPresenter#start does not make sense as an interface method. Every presenter reimplements a start() method with their specific argument (see sub-interfaces), so it is never a real entry point.

      BaseDialogPresenter#getI18nizer should not be there.
      The definition passed to info.magnolia.ui.dialog.BaseDialogPresenter#start should be already decorated. (tried to get to that but failed for 5.1)

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                fgrilli Federico Grilli
                fgrilli Federico Grilli
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD