Details
-
Bug
-
Resolution: Obsolete
-
Critical
-
None
-
5.1
-
None
-
None
Description
Fixes for MGNLUI-2135 are unsatisfactory.
One of the reasons is that some presenters pass an already-decorated definition to info.magnolia.ui.dialog.BaseDialogPresenter#start, and some don't. After an initial analysis with [@pbaerfuss], we thought we'd move that responsibility to the caller. After further investigation:
- There are "too many" places where this should occur, and that would somewhat hide/obscure the calls to I18nizer.
- DialogPresenter#start does not make sense as an interface method. Every presenter reimplements a start() method with their specific argument (see sub-interfaces), so it is never a real entry point.
BaseDialogPresenter#getI18nizer should not be there.
The definition passed to info.magnolia.ui.dialog.BaseDialogPresenter#start should be already decorated. (tried to get to that but failed for 5.1)
Checklists
Attachments
Issue Links
- clones
-
MGNLUI-2135 Forms and dialogs are not properly decorated
-
- Closed
-
- is related to
-
MGNLUI-2196 Revisit Dialog API and related concepts
-
- Closed
-
-
MAGNOLIA-5332 AbstractI18nKeyGenerator could expose method to get id or name of unknown i18n root object
-
- Closed
-