Details
-
Bug
-
Resolution: Obsolete
-
Neutral
-
None
-
5.1
-
None
-
None
Description
These classes are not abstract and are used as-is by apps, at least at clients. So the constructors should be public. We changed these classes from being abstract classes (MGNLUI-634) but never changed the access modifier. They're read using node2bean which doesn't care about the modifier but for testing having them protected is a problem.
The constructor in BaseSubApp should should also have the @Inject annotation, not that it makes any difference but for clarity it would be good if it was there.
Checklists
Acceptance criteria