-
Bug
-
Resolution: Fixed
-
Critical
-
5.2
-
None
-
None
-
-
Empty show more show less
-
5.2-rc1
The changes introduce by the modification of the nodeType definition in
https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=blob;f=magnolia-core/src/main/resources/mgnl-nodetypes/magnolia-nodetypes.xml;h=69a828e519cc073f3f556510cb8840d9cd0228b1;hb=c6af0a121f025699c509f2f1ecc0a1e0e9feb21c
produces test errors:
Once solve do not forget to
- reactivate the following test class: DialogMigrationTaskTest
- increase module coverage to 47
.
info.magnolia.module.delta.TaskExecutionException: Could not Migrate Dialog at info.magnolia.ui.dialog.setup.DialogMigrationTask.execute(DialogMigrationTask.java:168) at info.magnolia.ui.dialog.setup.DialogMigrationTaskTest.testExecuteExtendsMigration(DialogMigrationTaskTest.java:199) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) Caused by: javax.jcr.ItemExistsException: Node with the same UUID exists:node /modules/testModule/dialogs at org.apache.jackrabbit.core.xml.SessionImporter.startNode(SessionImporter.java:380) at org.apache.jackrabbit.core.xml.SysViewImportHandler.processNode(SysViewImportHandler.java:93) at org.apache.jackrabbit.core.xml.SysViewImportHandler.startElement(SysViewImportHandler.java:134) at org.apache.jackrabbit.core.xml.ImportHandler.startElement(ImportHandler.java:175) at org.apache.jackrabbit.commons.xml.DefaultContentHandler.startElement(DefaultContentHandler.java:161) at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source) at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source) at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source) at org.apache.jackrabbit.commons.xml.ParsingContentHandler.parse(ParsingContentHandler.java:62) at org.apache.jackrabbit.commons.AbstractSession.importXML(AbstractSession.java:344) at info.magnolia.jcr.wrapper.DelegateSessionWrapper.importXML(DelegateSessionWrapper.java:249) at info.magnolia.jcr.wrapper.DelegateSessionWrapper.importXML(DelegateSessionWrapper.java:249) at info.magnolia.jcr.wrapper.DelegateSessionWrapper.importXML(DelegateSessionWrapper.java:249) at info.magnolia.ui.dialog.setup.DialogMigrationTask.copyInSession(DialogMigrationTask.java:490) at info.magnolia.ui.dialog.setup.DialogMigrationTask.execute(DialogMigrationTask.java:150) ... 26 more
Acceptance criteria
- caused by
-
MGNLUI-2366 Remove unnecessary usage of copyInSession in Dialog Migration Task
- Closed
-
MAGNOLIA-5463 Change implementation of copyInSession so it works without same-name siblings.
- Closed
- is related to
-
MAGNOLIA-5434 Default node type definition should not allow same-name siblings
- Closed