Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2784

Fix jar plugin configuration of magnolia-ui-vaadin-common-widgets and magnolia-ui-widget-editor

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 5.2.4
    • None
    • None
    • None

    Description

      The pom files of these 2 modules currently configures maven-jar-plugin to generate an INDEX.LIST which is turn causing some build issues on some platforms. There is no reason for these jar entries to be there, and that configuration seems to have been copy-paste accidentally from some example. (AFAICT, it's been introduced in the m5-vaadin prototype, with m5-magnolia-shell in commit 118311761ba, and copied over multiple places since - and that in turn seems to come from the Vaadin-widget-project Maven archetype)

      It should look like this:

            <plugin>
              <groupId>org.apache.maven.plugins</groupId>
              <artifactId>maven-jar-plugin</artifactId>
              <configuration>
                <archive>
                  <!-- Remove this line: <index>true</index>-->
                  <manifest>
                    <!-- Remove this line: <addClasspath>true</addClasspath> -->
                    <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                  </manifest>
                  <manifestEntries>
                    <Vaadin-Package-Version>1</Vaadin-Package-Version>
                    <Vaadin-Widgetsets>
                      info.magnolia.ui.vaadin.editor.gwt.PageEditorWidgetSet
                    </Vaadin-Widgetsets>
                  </manifestEntries>
                </archive>
              </configuration>
            </plugin>
      

      (i.e remove <index> as well as <addClasspath>, which makes no sense for us either)

      This seems to fix issues with running integration tests on different machines (specifically, the issue where jsp compilation, for some reason, triggered {{InvalidJarIndexException}}s), so should allow our build infrastructure to grow faster, once fixed.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                gjoseph Magnolia International
                gjoseph Magnolia International
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD