Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2814

ENTER keyboard shortcut causes error in Move Dialog

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.2.5
    • 5.2.4
    • None
    • None

    Description

      To reproduce:

      • Select an asset.
      • Click "Move asset" action.
        > Dialog opens.
      • Select a new location in the dialog.
      • Hit ENTER key.
        > Red error bar appears - in pulse is message "An error occurred while executing an action. No definition exists for action: commit."

      However if you press the "MOVE INSIDE" button, the item is moved as expected.

      The problem relates to the fact that the ENTER keyboard attempts to trigger the action named "commit" which most dialogs have. (See BaseDialogPresenter#CommitDialogShortcutListener).
      Move dialog (see MoveDialogPresenterImpl) actually has three actions. The button that looks like the commit simply has a "commit" css class added to it.
      The complexity is that the MOVE INSIDE is only applicable if a user has selected a directory. So what SHOULD happen if user hits ENTER? MOVE BEFORE action triggered?

      Perhaps ENTER key should not be supported here.
      Perhaps the code throwing the exception should check for "commit" action and skip the exeption in that case.

      ERROR a.ui.contentapp.movedialog.MoveDialogPresenterImpl: An error occurred while executing an action.
      info.magnolia.ui.api.action.ActionExecutionException: No definition exists for action: commit
      at info.magnolia.ui.api.action.AbstractActionExecutor.createAction(AbstractActionExecutor.java:93)

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                peili.liang Peili Liang
                czimmermann Christopher Zimmermann
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD