Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-2981

NPE is logged when adding new favorite entry and user is not superuser

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 5.3.15, 5.4.7, 5.5
    • 5.3.12, 5.4.3
    • None
    • None
    • Yes
    • Saigon 45
    • 3

      Steps to reproduce:

      1. Log in as eric
      2. Open pages app and select "article" page
      3. Switch to Favorites
      4. Click to "Add new" and then "Add"
      5. New entry is correctly added, but in log you can find NPE
      2014-06-06 11:15:05,936 ERROR .ui.admincentral.shellapp.favorites.FavoritesEntry: Failed to create an itemId from an AbstractJcrNodeAdapter
      java.lang.NullPointerException
      	at info.magnolia.ui.admincentral.shellapp.favorites.FavoritesEntry.createItemdId(FavoritesEntry.java:325)
      	at info.magnolia.ui.admincentral.shellapp.favorites.FavoritesEntry.<init>(FavoritesEntry.java:94)
      	at info.magnolia.ui.admincentral.shellapp.favorites.FavoritesViewImpl.init(FavoritesViewImpl.java:159)
      	at info.magnolia.ui.admincentral.shellapp.favorites.FavoritesPresenter.initializeView(FavoritesPresenter.java:285)
      	at info.magnolia.ui.admincentral.shellapp.favorites.FavoritesPresenter.start(FavoritesPresenter.java:82)
      	at info.magnolia.ui.admincentral.shellapp.favorites.FavoritesShellApp.start(FavoritesShellApp.java:60)
      	at info.magnolia.ui.admincentral.shellapp.ShellAppController$ShellAppContextImpl.start(ShellAppController.java:157)
      	at info.magnolia.ui.admincentral.shellapp.ShellAppController.addShellApp(ShellAppController.java:90)
      	at info.magnolia.ui.admincentral.AdmincentralPresenter.<init>(AdmincentralPresenter.java:75)
      	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
      	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
      	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
      	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
      	at info.magnolia.objectfactory.ObjectManufacturer.newInstance(ObjectManufacturer.java:109)
      	at info.magnolia.objectfactory.ObjectManufacturer.newInstance(ObjectManufacturer.java:79)
      	at info.magnolia.objectfactory.guice.GuiceComponentProvider.newInstanceWithParameterResolvers(GuiceComponentProvider.java:121)
      	at info.magnolia.objectfactory.guice.GuiceComponentProvider.newInstance(GuiceComponentProvider.java:107)
      	at info.magnolia.ui.admincentral.AdmincentralUI.init(AdmincentralUI.java:120)
      	at com.vaadin.ui.UI.doInit(UI.java:610)
      	at com.vaadin.server.communication.UIInitHandler.getBrowserDetailsUI(UIInitHandler.java:223)
      	at com.vaadin.server.communication.UIInitHandler.synchronizedHandleRequest(UIInitHandler.java:73)
      	at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:37)
      	at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1371)
      	at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:238)
      	at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:131)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
      	at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:147)
      	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:90)
      	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
      	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      

      Solution

      Get item id for FavoritesEntry using AbstractJcrNodeAdapter#getItemId()

        Acceptance criteria

              hieu.nguyen Hieu Nguyen Duc
              mdivilek Milan Divilek
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD

                    Estimated:
                    Original Estimate - 4d Original Estimate - 4d
                    4d
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 5d 6.5h
                    5d 6.5h