Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3128

FormBuilder: defaultLocale in dialogs is always taken from the "default" site definiton

    XMLWordPrintable

Details

    Description

      When opening an edit dialog in page app, defaultLocale is taken from the default site and not from node-based I18NAuthoringSupport.

      Additionally, the DefaultI18NAuthoringSupport.i18nize(...) method wrongly uses the fallbackLocale to add a suffix to i18nizable properties. It should instead use the defaultLocale.

      Possible solution:
      • Add getDefaultLocale(Node node) and getI18nContentSupport(Node node) methods for DefaultI18nAuthoringSupport.
        • Used Extended18NAuthoringSupport as workaround (we don't want to change interface in minor version).
      • Use introspection to check if getDefaultLocale(Node node) method exists and invoke it if it is. Remove this once MGNLUI-3068 is done.

      Both solutions have in common:

      • Add getRelatedFormItem() to BasicTranformer and then using it in DefaultI18NAuthoringSupport.i18nize(...) to get node-based I18NAuthoringSupport from nodes created by FormBuilder.
      Notes

      The described behavior was also detected on the defaultLocale (MULTISITE-22).

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                pmundt Philip Mundt
                cringele Christian Ringele
                Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD